Closed
Bug 1868301
Opened 1 years ago
Closed 1 years ago
Fix clippy warnings in xpcom_macros/src/lib.rs
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox122 fixed)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox122 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: kevint3hu, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=rust])
Attachments
(1 file)
Filling as a good first bug to learn workflows.
xpcom/rust/xpcom/xpcom_macros/src/lib.rs
200:17 warning the borrowed expression implements the required traits clippy::needless_borrow (clippy)
361:10 warning this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` clippy::into_iter_on_ref (clippy)
Links to the code:
https://searchfox.org/mozilla-central/rev/78a2c17cc80680a5a82446e4ce7c45a73b935383/xpcom/rust/xpcom/xpcom_macros/src/lib.rs#200
https://searchfox.org/mozilla-central/rev/78a2c17cc80680a5a82446e4ce7c45a73b935383/xpcom/rust/xpcom/xpcom_macros/src/lib.rs#361
to run clippy:
./mach lint -l clippy xpcom/rust/xpcom/ -W
As the change is trivial, it is just to learn how to contribute to Firefox.
Tutorial to contribute:
https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html
https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html
Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
|
||
Updated•1 years ago
|
Assignee: nobody → kevint3hu
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63450ec33b5b
Fix clippy warnings in xpcom_macros/src/lib.rs. r=xpcom-reviewers,emilio
|
||
Comment 3•1 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 years ago
status-firefox122:
--- → fixed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•